🌱 Add integration test to avoid manager.Start deadlocks

[sbueringer]

For more context on the deadlock we had in the past:

• Improve test coverage for controller startup with conversion #2322
• 🐛 Revert: move health probes to runnable #2321

Fixes #2322

[sbueringer]

cc @alvaroaleman

[vincepri]

Is the listening address not exposed in any other way? Could we avoid relying on reflection to get a private value?

[sbueringer]

I couldn't find another way. The problem is that I don't have access to private fields.

I couldn't put this test in the manager package because of cyclic dependencies (and it's probably also better as an integration test if it's outside of the package).

Happy to change it if there is an alternative. I couldn't find any apart from exporting something in the Manager that we probably don't want to export

[sbueringer]

Should be all addressed/answered now. I moved the test below internal. While the _test.go didn't "leak" any exported types the v1/v2 packages did.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

unrelated flake

/retest