馃尡 Add logs around Reconcile call, change webhook logs to log level 5 #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
vincepri
reviewed
Jul 25, 2023
sbueringer
force-pushed
the
pr-add-reconcile-logs
branch
from
01ec9eb
to
9103fa7
Compare
k8s-ci-robot
added
size/S
sbueringer
changed the title
vincepri
approved these changes
Jul 28, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logs around the Reconcile call. I think this can be very useful to see which objects have been reconciled at which time.
I only added them on log level 4 because otherwise they would be very verbose.
This somewhat limits the benefit they have but they are still useful when running on high log-level or when it's possible to re-configure the log-level of the controller at runtime.