🐛 Fix Defaulting of the User Agent

[alvaroaleman]

This broke when we added the HTTP client, because the user-agent gets set by a roundtripper that is constructed within rest.HTTPClientFor. As a result, we have to default it before we do that. Currently, it ends up being defaulted to Go-http-client which is not very useful.

[FillZpp]

LGTM. Nit: the rest.DefaultKubernetesUserAgent() only contains the version of client-go, should we have a default user-agent that also shows the version of controller-runtime?

[alvaroaleman]

LGTM. Nit: the rest.DefaultKubernetesUserAgent() only contains the version of client-go, should we have a default user-agent that also shows the version of controller-runtime?

No real strong opinion either way, but I don't think that version is currently available to us?

[vincepri]

/lgtm

Merging this right now, given that it fixes the underlying bug. @FillZpp let's follow-up on having a more useful user agent with controller-runtime in mind

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

/cherrypick release-0.15

[k8s-infra-cherrypick-robot]

@alvaroaleman: #2435 failed to apply on top of branch "release-0.15":

Applying: bug: Fix Defaulting of the User Agent
Using index info to reconstruct a base tree...
M	pkg/cache/cache.go
M	pkg/cluster/cluster.go
M	pkg/manager/manager.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/manager/manager.go
CONFLICT (content): Merge conflict in pkg/manager/manager.go
Auto-merging pkg/cluster/cluster.go
Auto-merging pkg/cache/cache.go
CONFLICT (content): Merge conflict in pkg/cache/cache.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bug: Fix Defaulting of the User Agent
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.