Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveControllerReference in controllerutil bug. #2594

Closed
troy0820 opened this issue Nov 24, 2023 · 0 comments · Fixed by #2595
Closed

RemoveControllerReference in controllerutil bug. #2594

troy0820 opened this issue Nov 24, 2023 · 0 comments · Fixed by #2595
Assignees
@troy0820
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@troy0820
Copy link
Member

In pull request #2509 when using the RemoveControllerReference the function checks if ann owner exists but only removes the owner passed in which may not be the owner reference with controlled = true.

Update the function to ensure that the owner is in fact the controller reference to be removed.

/kind bug
/assign @troy0820
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 24, 2023
@troy0820 troy0820 mentioned this issue Nov 24, 2023
Merged
1 task
@troy0820 troy0820 changed the title Remove Controller Reference in util function. RemoveControllerReference in controllerutil bug. Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troy0820 troy0820

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛Remove owner passed in to RemoveControllerReference troy0820/controller-runtime
2 participants
@troy0820 @k8s-ci-robot