New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache #2611
⚠️ Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache #2611
Conversation
The discovery restmapper was unused except for two places that we missed (when creating a cache directly as opposed through the manager and in a test). The discovery restmapper only ever loads mappings once during startup and is unable to reload them if they change. It also isn't lazy and we don't want anyone using it.
/retest |
@alvaroaleman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle |
/lgtm |
The latter isn't remommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
The latter isn't remommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
The latter isn't recommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
The latter isn't remommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
The latter isn't recommended and was removed by kubernetes-sigs/controller-runtime#2611 in controller-runtime v0.17.0. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Use NewDynamicRESTMapper instead of NewDiscoveryRESTMapper (Ref: kubernetes-sigs/controller-runtime#2611)
The discovery restmapper was unused except for two places that we missed (when creating a cache directly as opposed through the manager and in a test). The discovery restmapper only ever loads mappings once during startup and is unable to reload them if they change. It also isn't lazy and we don't want anyone using it.
Instead, the
DynamicRESTMapper
should be used.