Remove deprecated webhook interfaces

[nathanperkins]

Context: #2596

After giving projects a few versions to migrate, we should remove the webhook.Validator and webhook.Defaulter interfaces to prevent this issue from happening.

[nathanperkins]

cc: @alvaroaleman

[troy0820]

/kind support

@nathanperkins This will probably have to be a couple of minor releases before removal to prevent churn? Also, Kubebuilder scaffold will probably have to implement the webhook generation to not include this as well.

[sbueringer]

cc @camilamacedo86 for awareness

[nathanperkins]

This will probably have to be a couple of minor releases before removal to prevent churn?

Yeah, do you have milestone tracking so that it can be added to a future version? We might want to update the deprecation message to say when it will be removed as well so that users know when they will need to remove it.

[nathanperkins]

Also, Kubebuilder scaffold will probably have to implement the webhook generation to not include this as well.

I asked them to look into it here:

kubernetes-sigs/kubebuilder#3721

[troy0820]

Yeah, do you have milestone tracking so that it can be added to a future version? We might want to update the deprecation message to say when it will be removed as well so that users know when they will need to remove it.

I do not, but if we announce the planned deprecation for this in v0.17.0 and deprecate it in v0.18.0 and then remove it in v0.19.0, it'll give a little run way to be planned around k8s releases. Since we are on 1.29 now, that'll also give kubebuilder a chance to implement their strategy for this around their release schedule as well.

We probably should mark this as part of the v0.17.0 milestone? @sbueringer

[nathanperkins]

I do not, but if we announce the planned deprecation for this in v0.17.0 and deprecate it in v0.18.0 and then remove it in v0.19.0, it'll give a little run way to be planned around k8s releases. Since we are on 1.29 now, that'll also give kubebuilder a chance to implement their strategy for this around their release schedule as well.

@alvaroaleman already added the deprecation notice for next version in #2596. The deprecation notice is just to encourage shifting new usage and migration to the other interface so it probably doesn't need to wait for an entire version to be added.

So maybe we can announce and deprecate in 0.17 and then remove in 0.19?

[alvaroaleman]

yeah the deprecation will definitely be in the next version, the removal we will see, 0.19 sounds reasonable I guess

[sbueringer]

I created a v0.19.x milestone and added it there for now. Let's see what sort of feedback / pushback we get from the deprecation.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sbueringer]

/remove-lifecycle stale

/lifecycle frozen