Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove deprecated manager options #2648

Merged
merged 3 commits into from Apr 18, 2024
Merged

⚠️ Remove deprecated manager options #2648

merged 3 commits into from Apr 18, 2024

Conversation

troy0820
Copy link
Member

options.AndFrom and options.AndFromOrDie have been deprecated over several releases. This PR will remove them where consumers will have to migrate to their own config solution.

  • Remove function options.AndFrom
  • Remove function options.AndFromOrDie

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch 3 times, most recently from d7b2929 to ff81e15 Compare January 11, 2024 00:01
camilamacedo86
camilamacedo86 reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code ensures that the options work
So, IMO it should only be removed when the options be removed and are no longer supported.

@inteon
Copy link
Member

inteon commented Jan 11, 2024 •
edited

👍 I think we can only remove these functions when we remove sigs.k8s.io/controller-runtime/pkg/config too.

@troy0820
Copy link
Member Author

This code ensures that the options work
So, IMO it should only be removed when the options be removed and are no longer supported.

The options.AndFrom was loading a config that @inteon agreed that we can only deprecate this if we deprecate the config package.

Do you mean that the options that get merged with the config options shouldn't be removed? This doesn't remove any options.

#895

👍 I think we can only remove these functions when we remove sigs.k8s.io/controller-runtime/pkg/config too.

Very true, I can delete those as well.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch from 2987663 to 5c3d4ba Compare January 11, 2024 15:09
@troy0820 troy0820 changed the title ⚠Remove manager options deprecation ⚠️ Remove manager options deprecation Jan 12, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch 2 times, most recently from 4e19ca7 to 8f4f42c Compare January 16, 2024 14:28
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch from 8f4f42c to 5f173b3 Compare January 23, 2024 18:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch 2 times, most recently from 9d0392c to 499f6d9 Compare January 23, 2024 20:23
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch from 499f6d9 to 8a15cc1 Compare January 26, 2024 02:30
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@troy0820 troy0820 mentioned this pull request Feb 8, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2024
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch from 8a15cc1 to 3f03627 Compare March 25, 2024 17:53
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2024
@sbueringer
Copy link
Member

/test pull-controller-runtime-test

@inteon
Copy link
Member

inteon commented Apr 11, 2024

/lgtm
PR LGTM, we now just need an approver to agree that we want to remove this deprecated feature already.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f74641a1791084522a47aa6e419a8770e74f2480

@troy0820
Copy link
Member Author

/lgtm PR LGTM, we now just need an approver to agree that we want to remove this deprecated feature already.

Thank you for the review, I know that this has to be coordinated and maybe targeted for v0.18.0.

sbueringer
sbueringer reviewed Apr 15, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@troy0820
remove options.AndFrom deprecation
d19f17b 
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820
remove config deprecations
bf87798 
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820
remove make target verify-generate
66154d3 
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/remove-deprecated-options branch from b89ab7f to 66154d3 Compare April 15, 2024 15:43
@sbueringer
Copy link
Member

Thank you very much!

/lgtm

/assign @alvaroaleman @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ae653961538db33bc11b6c147a59f99db23211f

@alvaroaleman alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 16, 2024
@alvaroaleman
Copy link
Member

/retitle ⚠️ Remove deprecated manager options

The current title sounds to me like we were un-deprecating something, WDYT?
/lgtm
/approve
/hold

In case @vincepri wants to have a look

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot changed the title ⚠️ Remove manager options deprecation ⚠️ Remove deprecated manager options Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@sbueringer
Copy link
Member

/hold cancel

/test pull-controller-runtime-test

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@sbueringer
Copy link
Member

@troy0820 Thank you very much!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 18, 2024 •
edited

@troy0820: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff 66154d3 link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 0470607 into kubernetes-sigs:main Apr 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@inteon inteon Awaiting requested review from inteon

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@vincepri vincepri

@sbueringer sbueringer

@alvaroaleman alvaroaleman

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@troy0820 @inteon @sbueringer @k8s-ci-robot @alvaroaleman @camilamacedo86 @vincepri