Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In favor of what is EventBroadcaster manager option deprecated? #2694

Open
valdar opened this issue Feb 22, 2024 · 1 comment
Open

In favor of what is EventBroadcaster manager option deprecated? #2694

valdar opened this issue Feb 22, 2024 · 1 comment
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@valdar
Copy link

valdar commented Feb 22, 2024 •
edited

The EventBroadcaster manager option has been deprecated for a while:

controller-runtime/pkg/manager/manager.go

Lines 248 to 253 in 5615941

// EventBroadcaster records Events emitted by the manager and sends them to the Kubernetes API
// Use this to customize the event correlator and spam filter
//
// Deprecated: using this may cause goroutine leaks if the lifetime of your manager or controllers
// is shorter than the lifetime of your process.
EventBroadcaster record.EventBroadcaster

Are there suggested alternatives?

The deprecation comment seems more a warning of usage than anything else; might be that "Deprecated" is the wrong wording?
@valdar
Copy link
Author

valdar commented Feb 22, 2024

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Feb 22, 2024
@lburgazzoli lburgazzoli mentioned this issue Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valdar @k8s-ci-robot