Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump to k/k 1.30 RC2, downgrade prometheus, zap, golang.org/x/sys, sigs.k8s.io/yaml #2776

Merged
merged 1 commit into from Apr 15, 2024

Conversation

sbueringer
Copy link
Member

to k/k versions

Signed-off-by: Stefan B眉ringer buringerst@vmware.com

Context: we had some problems with compile issues with prometheus/client_.* caused by diverging versions between CR & k/k

#2774 will introduce a tool that ensure the dependencies are always sync. The current PR downgrades the dependencies that are currently out of sync.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2024
@sbueringer
Copy link
Member Author

I'll take a look at the finding in a bit

go.mod Show resolved Hide resolved
to k/k versions

Signed-off-by: Stefan B眉ringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2024
@sbueringer sbueringer changed the title 馃尡 Downgrade prometheus/client_*, zap, golang.org/x/sys, sigs.k8s.io/yaml 馃尡 Bump to k/k 1.30 RC2, downgrade prometheus, zap, golang.org/x/sys, sigs.k8s.io/yaml Apr 15, 2024
@sbueringer
Copy link
Member Author

@vincepri PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1257c094b5003c69baf977fb0ec3dcd99062d98c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08799f6 into kubernetes-sigs:main Apr 15, 2024
12 checks passed
@sbueringer sbueringer deleted the pr-downgrade branch April 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants