Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to ignore globalPredicates for specific resources #2785

Open
johscheuer opened this issue Apr 17, 2024 · 1 comment
Open

Allow to ignore globalPredicates for specific resources #2785

johscheuer opened this issue Apr 17, 2024 · 1 comment

Comments

@johscheuer
Copy link
Contributor

In the current implementation of the controller-runtime builder the global predicates added with WithEventFilter will be added to all resources. There could be cases where the global predicates should be added to all resources except for one, e.g. when watching external managed resources like nodes. Right know the only solution is to remove the WithEventFilter and add the previous global predicates to the For and all Owns calls and then add the Watches with the dedicated predicate. I'm happy to help implement this feature if others think that would be a useful feature.

@alvaroaleman
Copy link
Member

Being global is pretty much the purpose of a global predicate ;) Any suggestions as to how the API for this could look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants