✨ Add TransformStripManagedFields #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
alvaroaleman
force-pushed
the
add-default-transform
branch
from
01dce5f
to
742fa6c
Compare
alvaroaleman
changed the title
alvaroaleman
force-pushed
the
add-default-transform
branch
2 times, most recently
from
a7015d9
to
85aa0fc
Compare
This change adds `TransformStripManagedFields` to the Cache, a transform func that strips off all managed fields for objects. There are no known issues when using this as a `DefaultTransform` unless there is explicit code to access objects `ManagedFields` and can lead to a significant reduction in memory usage.
alvaroaleman
force-pushed
the
add-default-transform
branch
from
85aa0fc
to
4cf9db0
Compare
Danil-Grigorev
approved these changes
Apr 21, 2024
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8bfda55969144726bdabcfb9c7cad9a597b588a0
|
|
Thx!! /approve /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, Danil-Grigorev, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
TransformStripManagedFieldsto the Cache, a transform func that strips off all managed fields for objects. There are no known issues when using this as aDefaultTransformunless there is explicit code to access objectsManagedFieldsand it can lead to a significant reduction in memory usage.