✨ envtest utility, defaultable flags #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
DirectXMan12
force-pushed
the
example/scratch-env
branch
from
53c9f33
to
9700a52
Compare
|
/kind feature |
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
needs-rebase
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
This defaults the value of `--zap-devel` to whatever is in the options struct. This allows programs to set a "prefered" default. Since folks would already be passing an empty options struct, this shouldn't affect any existing users (famous last words).
DirectXMan12
force-pushed
the
example/scratch-env
branch
from
9700a52
to
d756017
Compare
k8s-ci-robot
removed
the
needs-rebase
DirectXMan12
force-pushed
the
example/scratch-env
branch
from
d756017
to
0746e52
Compare
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
vincepri
reviewed
Sep 29, 2020
|
/milestone v0.7.x |
This adds a standalone example of envtest not being used in testing. It's super useful for interactive testing of controller and webhook behavior, and code I've written in various forms for a one-off at least a dozen times.
DirectXMan12
force-pushed
the
example/scratch-env
branch
from
0746e52
to
9b650c1
Compare
|
all fixed up |
k8s-ci-robot
added
the
lgtm
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small example/utility that lets you run envtest as a standalone binary. I've probably written this code about 20 times in
/tmp/xyz-debugwhen debugging controller issues or reproducing apiserver behavior, so I figured it was time to push it somewhere.This also tweaks the way a flag gets initialized in the zap flags so that the value passed to options gets set as the default for
--zap-devel. This should make that flag behave like the other flags -- if you pass a "default" via the options struct and the user doesn't set the flag, they'll get that default.