Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Flag/Arg Parsing Library Fails On Octal-looking Strings #879

Open
stevekuznetsov opened this issue Feb 5, 2024 · 3 comments
Open
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@stevekuznetsov
Copy link
Contributor

Randomly-generated tmpdirs used as outputs for CRD gen can trip up the options parser in this repo:

Error: unable to parse option \"output:crd:dir=./tmp.08cAgAZQNm/chart/crds\": [invalid digit '8' in octal literal (at <input>:1:7)]
@JoelSpeed
Copy link
Contributor

I believe I've seen this one before, and it's because the random part of the temp dir begins with a 0. We just made sure not to allow leading zeros

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Feb 6, 2024

@JoelSpeed yes, that's the bug. This repository has it's own bespoke argument parsing implementation, which is where the bug lives.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants