Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary --- in beginning of YAMLs created by controller-gen #909

Open
mateusoliveira43 opened this issue Apr 9, 2024 · 2 comments
Open

Comments

@mateusoliveira43
Copy link

Using this test project https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4 as an example, if you run make run, which under the rug runs

controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases

4 YAML files will be created: 3 CRDs https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4/config/crd/bases and 1 ClusterRole https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/config/rbac/role.yaml

All this files have a --- at the beginning of their files, which is unnecessary.

Can it be removed? thanks!

@sbueringer
Copy link
Member

Not sure if it's unnecessary. I wonder if some folks are just concatenating the files we generate and then this line would be missing.

So this could break a lot of folks

@sbueringer
Copy link
Member

Let's see if anyone else has context on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants