Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 return a bit more verbosy error messages for go-package errors #725

Merged
merged 2 commits into from Nov 17, 2022

Conversation

AlmogBaku
Copy link
Member

When having sub-packages, and one of them is out of sync, we might get an error such as:

err: exit status 1: stderr: go: updates to go.mod needed; to update it:
        go mod tidy

Although this error is true, it was a nightmare to debug it and figure out that it was related to a sub-package.

This PR introduces a bit more verbosy error message that can help you to debug the issue:

Error: error in /Users/AlmogBaku/projects/myproject/subpackage: err: exit status 1: stderr: go: updates to go.mod needed; to update it:
        go mod tidy

…d. This is useful to debug issues when having sub-packages
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 18, 2022
@AlmogBaku
Copy link
Member Author

might be related to #718

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2022
@AlmogBaku
Copy link
Member Author

/assign @mengqiy

pkg/loader/loader.go Outdated Show resolved Hide resolved
Co-authored-by: Joe Lanford <joe.lanford@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022
@deepankarm
Copy link

Any updates on when this PR can be merged? It indeed is a nightmare to debug.

@camilamacedo86
Copy link
Member

The requested changes by @joelanford are addressed so we can :

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2022
@camilamacedo86 camilamacedo86 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: AlmogBaku, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a41380f into kubernetes-sigs:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants