🐛 Fix the generation of listType=set

[alvaroaleman]

It has to have x-kubernetes-map-type: atomic set.

Fixes #752

[vincepri]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alvaroaleman]

tide?

[apelisse]

That's bogus to be honest, we're actually not accepting sets of atomic elements (even though that's what the validation says), only scalars can be part of a set.

[JoelSpeed]

I just checked and the following is valid without the atomic flag set, the issue raised in the original issue is because they used an type: object within the set, which must then be atomic according to the current validations.

              set:
                description: Tests the generation of a set list type
                items:
                  type: string
                type: array
                x-kubernetes-list-type: set

[apelisse]

Yes, a set to "strings" is fine, the validation says that if it's an object, it should be atomic, but that's actually wrong too. So making things atomic will fix the validation error, but will break server-side apply and other merge semantics.

[alvaroaleman]

@apelisse so what is correct? The corev1 api has this on the ResourceRequirements type at the ResourceClaim field. ResourceRequirements is port of corev1.Container, without this patch all crds foir apis that use anything that ends up using a corev1.Container get rejected.

[JoelSpeed]

The upstream API is invalid, we are going to fix the upstream API and get that backported to 1.26, working on that in kubernetes/kubernetes#114585

[liggitt]

agreed, please revert this change... overwriting the list type like this will break more things than it fixes in the long term, and produce CRDs that don't behave as expected