Implement the --filter flag for images command.

[roman-kiselenko]

The following filters are available:

1. dangling=(true/false)
2. reference=regex
3. before=<image-name>[:<tag>]|<image id>|<image@digest>
4. since=<image-name>[:<tag>]|<image id>|<image@digest>

What type of PR is this?

/kind documentation
/kind feature

What this PR does / why we need it:

Filtering images is a good feature for cluster admins; we need a filter flag for the crictl images command to reduce shell scripts complexity.

Which issue(s) this PR fixes:

Fixes #1256

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Implemented the `--filter` flag for `crictl images` command.
The following filters are available:

1. `dangling=(true/false)`
2. `reference=regex`
3. `before=<image-name>[:<tag>]|<image id>|<image@digest>`
4. `since=<image-name>[:<tag>]|<image id>|<image@digest>`

/c @kubernetes-sigs/cri-tools

[k8s-ci-robot]

Welcome @roman-kiselenko!

It looks like this is your first PR to kubernetes-sigs/cri-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cri-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[roman-kiselenko]

/c @saschagrunert @kwilczynski

[roman-kiselenko]

What is wrong with docs/ctrctl.1 🤔 ?

[kwilczynski]

@roman-kiselenko, thank you! This is great! 🚀

[kwilczynski]

What is wrong with docs/ctrctl.1 🤔 ?

@roman-kiselenko, you might have to generate an updated version. Would be my guess.

This would be to reflect the new command-line argument addition, etc.

[roman-kiselenko]

What is wrong with docs/ctrctl.1 🤔 ?

@roman-kiselenko, you might have to generate an updated version. Would be my guess.

This would be to reflect the new command-line argument addition, etc.

Thanks 🙏 docs are updated. go-md2man -in docs/crictl.md -out docs/crictl.1

[kwilczynski]

/retitle Implement the --filter flag for images command

[k8s-ci-robot]

@kwilczynski: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle Implement the --filter flag for images command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roman-kiselenko, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kwilczynski]

Suggested change

	return []*pb.Image{}, fmt.Errorf("Unknown filter flag: %v", filter)
	return []*pb.Image{}, fmt.Errorf("unknown filter flag: %s", filter)

[kwilczynski]

@roman-kiselenko, I am sorry for the late review!

@saschagrunert made me realise that I forgot to submit my review comments earlier. Doh!

Let me know what you think about some of the comments.

[roman-kiselenko]

@roman-kiselenko, I am sorry for the late review!

@saschagrunert made me realise that I forgot to submit my review comments earlier. Doh!

Let me know what you think about some of the comments.

@kwilczynski

no problem at all, I'll take care of your comments in another PR 😁