Support websocket transport for exec and attach #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows end users to choose the transport to be used as well as runtime developers to experiment on feature development. Supersedes: kubernetes-sigs#1305 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
SergeyKanzhelev
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
/lgtm
As commented before: #1305 (comment) I like the transport field approach better as it will allow to troubleshoot if specific transport works or not
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows end users to choose the transport to be used as well as runtime developers to experiment on feature development.
Which issue(s) this PR fixes:
Supersedes: #1305
Special notes for your reviewer:
cc @duguhaotian
Does this PR introduce a user-facing change?