Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXT registry: only handle forward migration #4358

Open
vmax opened this issue Apr 3, 2024 · 0 comments · May be fixed by #4359
Open

TXT registry: only handle forward migration #4358

vmax opened this issue Apr 3, 2024 · 0 comments · May be fixed by #4359
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@vmax
Copy link

vmax commented Apr 3, 2024

What happened:

I'm developing a webhook provider. Underlying DNS provider rejects trying to create CNAME and TXT record of the same name (which abides by the RFC AFAIR). However I see that it attempts to create both old-style and new-style DNS TXT records:

  • old-style: test.example.com --> "heritage=external-dns,external-dns/owner=default,external-dns/resource=ingress/default/test"
  • new-style: cname-test.example.com --> "heritage=external-dns,external-dns/owner=default,external-dns/resource=ingress/default/test"

New-style records are created just fine (as they don't conflict with CNAME).

However, on the next run it still tries to create old-style records (as txt/force-update: true provider-specific property has been assigned)

What you expected to happen:

Registry is constructed from new-style records only; absence of old records is discarded

How to reproduce it (as minimally and precisely as possible):

WIP

Anything else we need to know?:

I believe the fix would be to either:

  • allow using new-style records only
  • do not attempt to create old-style TXT records for CNAME endpoints if new-style records are present

Environment:

  • External-DNS version (use external-dns --version): unknown (f5545b1e164776958fbb85ed055ae418fb0f24dc)
  • DNS provider: webhook
  • Others:
@vmax vmax added the kind/bug Categorizes issue or PR as related to a bug. label Apr 3, 2024
@vmax vmax linked a pull request Apr 3, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant