Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added comment for serverProxyMode #291

Closed
wants to merge 1 commit into from
Closed

added comment for serverProxyMode #291

wants to merge 1 commit into from

Conversation

chetak123
Copy link
Member

Fixes #289

I have added comment for serverProxyMode in ipvs.go file.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @chetak123!

It looks like this is your first PR to kubernetes-sigs/kpng 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kpng has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2022
@jayunit100
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetak123, jayunit100

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@jayunit100 jayunit100 mentioned this pull request Jul 1, 2022
Closed
jayunit100
jayunit100 reviewed Jul 24, 2022
View reviewed changes
backends/ipvs-as-sink/ipvs.go
@@ -284,6 +284,9 @@ func (s *Backend) SetUpHttpListen() error {
return <-errCh
}


// ServeProxyMode used for creating the type of proxy which can be tested by proxyMode in service.go e2e test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we mean by "type of proxy" here? I've already forgotten why we had to port this in from the original codebase in kubernetes/kubernetes

@mcluseau
Copy link
Contributor

Unresolved conversation since jul 24, closing until someone reopens.

@mcluseau mcluseau closed this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayunit100 jayunit100 jayunit100 left review comments

@mcluseau mcluseau Awaiting requested review from mcluseau

@VivekThrivikraman-est VivekThrivikraman-est Awaiting requested review from VivekThrivikraman-est

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a quick comment/link back to the service.go e2e
4 participants
@chetak123 @k8s-ci-robot @jayunit100 @mcluseau