Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make makefile more idempotent / maybe Make it a taskfile (begginer issue) #378

Open
jayunit100 opened this issue Oct 14, 2022 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jayunit100
Copy link
Contributor

jayunit100 commented Oct 14, 2022

Intentionally leaving this vauge: Whoever picks it up can chose how to do it. Fun issue to start with . Either

  • fix the makefile targets so they all work OOTB (for example by running eval "$(curl -sL https://raw.githubusercontent.com/travis-ci/gimme/master/gimme | GIMME_GO_VERSION=1.18beta1 bash)" beforehand ... or confirming GOLang version...
  • in the process if folks want to get rid of make targets and replace them w/ a Taskfile (taskfile.dev) , and make those work ootb , thats find to

Can someone get these targets all functioning ? or maybe even rewrite it as a https://taskfile.dev/

/good-first-issue

@jayunit100 jayunit100 changed the title s/Makefile/Taskfile ? Or just fix it . Make makefile more idempotent / maybe Make it a taskfile (begginer issue) Oct 14, 2022
@jayunit100
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@jayunit100:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 14, 2022
@adityadtu5
Copy link

/assign

@emabota
Copy link
Contributor

emabota commented Dec 19, 2022

/assign
Hi @adityadtu5, are you still working on this issue? Have you come up with a plan/idea for how to work on it? Are you going to stick with makefiles or rewrite it in taskfiles?

@jayunit100
Copy link
Contributor Author

for now, i think running targets one at a time and seeing what works/doesnt and fixing them is a good start. then can decide on the taskfile part later if we want it

@brunopecampos
Copy link
Contributor

/assign
I'll add some an error when trying to run make tilt-up without previously running make tilt-setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants