Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s 1.23.3 to get bug fixes #2502

Closed
camilamacedo86 opened this issue Feb 1, 2022 · 8 comments · Fixed by #2575 or #2584
Closed

Bump k8s 1.23.3 to get bug fixes #2502

camilamacedo86 opened this issue Feb 1, 2022 · 8 comments · Fixed by #2575 or #2584
Assignees
@NikhilSharmaWe
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
3.4.0

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

Bump k8s 1.23.3 to get bug fixes

Extra Labels

No response
@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 1, 2022
@camilamacedo86
Copy link
Member Author

We need also to bump controller-runtime before.
Then, bump the new c+r version on kb and the k8s version used in the Kubebuilder scaffolds.

c/c @varshaprasad96

@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 10, 2022
@camilamacedo86 camilamacedo86 added this to the 3.4.0 milestone Feb 23, 2022
@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Mar 20, 2022 •
edited

@camilamacedo86

  • I am understanding about bumping sigs.k8s.io/controller-runtime version, but what do you mean by

Bump k8s 1.23.3 to get bug fixes

Because k8s alone is not a package so we cannot import it in go.mod as dependency, I think I am not able to properly understand your point here. Could you please elaborate.

@camilamacedo86
Copy link
Member Author

Here we need to:

@NikhilSharmaWe NikhilSharmaWe mentioned this issue Mar 22, 2022
Merged
@NikhilSharmaWe
Copy link
Member

/assign

@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Mar 22, 2022 •
edited

@camilamacedo86 Updated k8s dependencies in kubernetes-sigs/controller-runtime. kubernetes-sigs/controller-runtime#1843

This was referenced Mar 29, 2022
Closed
Merged
@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Mar 30, 2022 •
edited

@camilamacedo86 Made another PR kubernetes-sigs/controller-runtime#1853 upgrading k8s dependencies for branch release-0.11 in https://github.com/kubernetes-sigs/controller-runtime. Since it is merged now, can we now start working on this issue ?

@NikhilSharmaWe NikhilSharmaWe mentioned this issue Mar 30, 2022
Merged
@camilamacedo86
Copy link
Member Author

To close this one is missing bump C+r and then ensure that all scaffolds will also be updated.

@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Mar 31, 2022 •
edited

@camilamacedo86
Could you please confirm, So we have to -

And run make generate.

Could you please inform whether this is what needs to be done or not. Or we have to just execute the first point.

@NikhilSharmaWe NikhilSharmaWe mentioned this issue Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikhilSharmaWe NikhilSharmaWe

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
3.4.0
2 participants
@camilamacedo86 @NikhilSharmaWe