Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the implementation of the v1beta1 CRD dependency downgrade logic #2710

Closed
everettraven opened this issue Jun 7, 2022 · 2 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@everettraven
Copy link
Contributor

What do you want to happen?

The logic that performs the dependency downgrades to support v1beta1 CRDs needs to be cleaned up.

The following PR implemented a way to remove all indirect dependencies and repopulate them with go mod tidy but did not remove the now obsolete replacement of indirect dependencies.
PR: #2679

Along with this, there should be a warning logged that informs users of the fact that v1beta1 CRDs are not supported in Kubernetes v1.22+ and that as a result Kubebuilder is downgrading certain dependencies to enable this functionality.

Extra Labels

No response

@everettraven everettraven added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2022
@camilamacedo86
Copy link
Member

camilamacedo86 commented Jun 21, 2022

The v1beta1 is deprecated and we do not want to encourage people to use it.
Projects built with will not work from k8s 1.22 so do you think that is valid we spend effort on these improvements?

I am totally cool if someone sends any RFE/pr for improvements.

@everettraven
Copy link
Contributor Author

I agree that we shouldn't focus on this since it is being deprecated and removed in the future. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants