Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace component-config with our implemntation #725

Closed
3 tasks
tenzen-y opened this issue Apr 26, 2023 · 6 comments · Fixed by #889
Closed
3 tasks

Replace component-config with our implemntation #725

tenzen-y opened this issue Apr 26, 2023 · 6 comments · Fixed by #889
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Apr 26, 2023

What would you like to be added:
We should migrate the component-config to another logic.

Why is this needed:
The controller-runtime community announces that the component-config (https://github.com/kubernetes-sigs/controller-runtime/tree/dca0be70fd22d5200f37d986ec83450a80295e59/pkg/config) is deprecated and will be removed in the future.

Ref:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@tenzen-y tenzen-y added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 26, 2023
@alculquicondor
Copy link
Contributor

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels May 3, 2023
@tenzen-y
Copy link
Member Author

@alculquicondor We need to work on this before bumping k8s module to v1.27 because controller-runtime v.0.15 doesn't populate parameters to ctrl.Option, and many lint errors have occurred.

ref: #880

If we put component-config in the kueue repository, do we need to upgrade componentConfig's apiVersion to v1beta2?

@alculquicondor
Copy link
Contributor

No, we only need to bump the version if we need to remove fields from the schema (in the CustomResourceDefinition itself)

@tenzen-y
Copy link
Member Author

No, we only need to bump the version if we need to remove fields from the schema (in the CustomResourceDefinition itself)

I see. Thanks!

@trasc
Copy link
Contributor

trasc commented Jun 21, 2023

/assign

@tenzen-y
Copy link
Member Author

/assign

Thanks for taking this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants