[refactor]: Internalize loader api #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
13 tasks
|
Thanks for the PR @varshaprasad96! @koba1t could you give this a review? The related issue is #3942 /assign @koba1t |
koba1t
requested changes
Jun 7, 2023
There was a problem hiding this comment.
@varshaprasad96
I've commented on a minor change.
Could you check it?
k8s-ci-robot
added
the
needs-rebase
varshaprasad96
force-pushed
the
refactor/api
branch
from
686c47b
to
67516e6
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@natasha41575 @annasong20 Could we merge this? Thanks! |
k8s-ci-robot
added
the
needs-rebase
varshaprasad96
force-pushed
the
refactor/api
branch
from
67516e6
to
154884a
Compare
k8s-ci-robot
removed
lgtm
|
/assign |
|
@varshaprasad96 some tests are failing, could you address those? |
varshaprasad96
force-pushed
the
refactor/api
branch
from
154884a
to
b233d1a
Compare
varshaprasad96
force-pushed
the
refactor/api
branch
from
b233d1a
to
e8cc46d
Compare
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR intends to move the loader api to internal. Only the necessary methods which are needed for the api have been put into `pkg/loader.go`. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
varshaprasad96
force-pushed
the
refactor/api
branch
from
e8cc46d
to
7911b2c
Compare
k8s-ci-robot
removed
the
lgtm
|
/remove hold |
|
/hold cancel |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to move the loader api to
internal. Only the necessary methods which
are needed for the api have been put into
pkg/loader.go.