Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to json-patch v5 #5197

Merged
merged 1 commit into from Aug 28, 2023
Merged

Switch to json-patch v5 #5197

merged 1 commit into from Aug 28, 2023

Conversation

skitt
Copy link
Member

@skitt skitt commented Jun 9, 2023

json-patch was bumped to v5 in k/k as a result of
kubernetes/kubernetes#118384; this aligns with that, but switches to the v5 module, which is documented as gopkg.in/evanphx/json-patch.v5.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @skitt!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @skitt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2023
@skitt skitt mentioned this pull request Jun 9, 2023
Closed
@koba1t
Copy link
Member

koba1t commented Jun 13, 2023

/ok-to-test
/triage accepted
/kind cleanup
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
@koba1t
Copy link
Member

koba1t commented Jun 13, 2023

Hi @skitt
Thanks for your PR!

I found two go.sum files that weren't updated.

        modified:   cmd/pluginator/go.sum
        modified:   plugin/builtin/iampolicygenerator/go.sum

Could you try exec for ./hack/doGoMod.sh tidy command?

@skitt
Copy link
Member Author

skitt commented Jun 13, 2023

Could you try exec for ./hack/doGoMod.sh tidy command?

Done, thanks for the tip!

@koba1t
Copy link
Member

koba1t commented Jun 13, 2023

Done, thanks for the tip!

No problem! Thanks for your update!
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 13, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 20, 2023
@koba1t
Copy link
Member

koba1t commented Jun 20, 2023

/lgtm
/cc @natasha41575 @annasong20

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@annasong20
Copy link
Contributor

/test all

@annasong20
Copy link
Contributor

/lgtm
@skitt Can you push again to try to trigger test execution? I'll approve after tests pass. Thank you!

@skitt
Switch to json-patch v5
b692e49 
json-patch was bumped to v5 in k/k as a result of
kubernetes/kubernetes#118384; this aligns with
that, but switches to the v5 module, which is documented as
gopkg.in/evanphx/json-patch.v5.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2023
@skitt
Copy link
Member Author

skitt commented Aug 28, 2023

I’ll close and re-open this to see if that triggers the tests.

@skitt skitt closed this Aug 28, 2023
@skitt skitt reopened this Aug 28, 2023
@annasong20
Copy link
Contributor

@skitt The closing and re-opening did it! The tests are now running.

@annasong20
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 76f8d28 into kubernetes-sigs:master Aug 28, 2023
9 checks passed
@skitt skitt deleted the json-patch.v5 branch August 28, 2023 16:42
@howardjohn howardjohn mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba1t koba1t Awaiting requested review from koba1t

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@annasong20 annasong20 Awaiting requested review from annasong20

Assignees

@koba1t koba1t

@annasong20 annasong20

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skitt @k8s-ci-robot @koba1t @annasong20