Can't patch Pod - no matches for Id Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte

[AurimasNav]

What happened?

I am unable to patch a pod from specific helm chart.
I was not able to replicate this with plain yaml files, only in with this helm chart.

What did you expect to happen?

one of the resources from this helm chart is a pod:

apiVersion: v1
kind: Pod
metadata:
  annotations:
    helm.sh/hook: post-install, post-upgrade
    helm.sh/hook-delete-policy: hook-succeeded, before-hook-creation
  name: airbyte-minio-create-bucket
  namespace: airbyte

I expect it to patch with my label successfully, however it produces an error:

Error: no resource matches strategic merge patch "Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte": no matches for Id Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte; failed to find unique target for patch Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte

How can we reproduce it (as minimally and precisely as possible)?

kustomization.yaml

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: airbyte

patches:
- path: no-istio-sidecar.yaml

helmGlobals:
  chartHome: charts
helmCharts:
- name: airbyte
  version: 0.64.81
  repo: https://airbytehq.github.io/helm-charts
  releaseName: airbyte
  includeCRDs: true
  namespace: airbyte
  valuesFile: values.yaml

no-istio-sidecar.yaml

apiVersion: v1
kind: Pod
metadata:
  name: airbyte-minio-create-bucket
  namespace: airbyte
  labels:
   sidecar.istio.io/inject: "false"

values.yaml

global:
  jobs:
    resources:
      requests:
        cpu: 1m
        memory: 128Mi
      limits:
        cpu: 1
        memory: 1Gi
airbyte-api-server:
  resources:
    requests:
      cpu: 1m
      memory: 32Mi
    limits:
      cpu: 1
      memory: 1Gi
connector-builder-server:
  resources:
    requests:
      cpu: 1m
      memory: 32Mi
    limits:
      cpu: 1
      memory: 1Gi
cron:
  resources:
    limits:
      cpu: 1
      memory: 1Gi
    requests:
      cpu: 1m
      memory: 32Mi
pod-sweeper:
  resources:
    limits:
      cpu: 1
      memory: 1Gi
    requests:
      cpu: 1m
      memory: 32Mi
temporal:
  resources:
    limits:
      cpu: 1
      memory: 1Gi
    requests:
      cpu: 1m
      memory: 32Mi
webapp:
  resources:
    requests:
      cpu: 1m
      memory: 32Mi
    limits:
      cpu: 1
      memory: 1Gi
worker:
  resources:
    requests:
      cpu: 1m
      memory: 32Mi
    limits:
      cpu: 1
      memory: 1Gi
workload-launcher:
  containerOrchestrator:
    enabled: false
  resources:
    limits:
      cpu: 1
      memory: 1Gi
    requests:
      cpu: 1m
      memory: 32Mi

Expected output

apiVersion: v1
kind: Pod
metadata:
  annotations:
    helm.sh/hook: post-install, post-upgrade
    helm.sh/hook-delete-policy: hook-succeeded, before-hook-creation
  name: airbyte-minio-create-bucket
  namespace: airbyte
  labels:
    sidecar.istio.io/inject: "false"

Actual output

Error: no resource matches strategic merge patch "Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte": no matches for Id Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte; failed to find unique target for patch Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte

Kustomize version

v5.4.1

Operating system

MacOS

[k8s-ci-robot]

@harshsingh32: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to this:

/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stormqueen1990]

Hello there, @AurimasNav!

I took a look at this Helm chart by running helm template and noticed that the Pod you're alluding to doesn't have a namespace set in the chart prior to kustomize build:

# Source: airbyte/templates/minio.yaml
# This pod creates the state-storage bucket in the minio server,
# which the local cloud deployment requires to store its state.
apiVersion: v1
kind: Pod
metadata:
  name: airbyte-minio-create-bucket
  annotations:
    "helm.sh/hook": post-install, post-upgrade
    "helm.sh/hook-delete-policy": hook-succeeded, before-hook-creation
spec:
  ...

I could also confirm this is the case here: https://github.com/airbytehq/airbyte-platform/blob/801feb0da0af30b86961c0e92b8e0ae72000016a/charts/airbyte/templates/minio.yaml#L110-L119

Therefore, for your patch to get correctly applied, it would have to be:

apiVersion: v1
kind: Pod
metadata:
  name: airbyte-minio-create-bucket
  labels:
    sidecar.istio.io/inject: "false"

After updating the patch as specified above, I can correctly generate the manifests with kustomize build:

apiVersion: v1
kind: Pod
metadata:
  annotations:
    helm.sh/hook: post-install, post-upgrade
    helm.sh/hook-delete-policy: hook-succeeded, before-hook-creation
  labels:
    sidecar.istio.io/inject: "false"
  name: airbyte-minio-create-bucket
  namespace: airbyte
spec:
  ...

Could you please confirm it works for you after the aforementioned change?

/kind support

[stormqueen1990]

/triage needs-information