Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit hack/verify-crdgen.sh #465

Closed
Huang-Wei opened this issue Dec 19, 2022 · 0 comments · Fixed by #479
Closed

Revisit hack/verify-crdgen.sh #465

Huang-Wei opened this issue Dec 19, 2022 · 0 comments · Fixed by #479
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@Huang-Wei
Copy link
Contributor

kubernetes-sigs/controller-tools#691 has been merged, so once there is a new version of controller-gen, we should be able to remove the hacking logic in hack/verify-crdgen.sh, by adding a new comment in types.go:

For example:

// +kubebuilder:metadata:annotations="api-approved.kubernetes.io=https://github.com/kubernetes-sigs/scheduler-plugins/pull/50"
type PodGroup struct {
@Huang-Wei Huang-Wei added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 19, 2022
@lianghao208 lianghao208 mentioned this issue Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revisit hack/verify-crdgen.sh lianghao208/scheduler-plugins
1 participant
@Huang-Wei