Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/apimachinery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.28.2
Choose a base ref
...
head repository: kubernetes/apimachinery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.28.3
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Oct 8, 2023

  1. Prevent rapid reset http2 DOS on API server

    This change fully addresses CVE-2023-44487 and CVE-2023-39325 for
    the API server when the client is unauthenticated.
    
    The changes to util/runtime are required because otherwise a large
    number of requests can get blocked on the time.Sleep calls.
    
    For unauthenticated clients (either via 401 or the anonymous user),
    we simply no longer allow such clients to hold open http2
    connections.  They can use http2, but with the performance of http1
    (with keep-alive disabled).
    
    Since this change has the potential to cause issues, the
    UnauthenticatedHTTP2DOSMitigation feature gate can be disabled to
    remove this protection (it is enabled by default).  For example,
    when the API server is fronted by an L7 load balancer that is set up
    to mitigate http2 attacks, unauthenticated clients could force
    disable connection reuse between the load balancer and the API
    server (many incoming connections could share the same backend
    connection).  An API server that is on a private network may opt to
    disable this protection to prevent performance regressions for
    unauthenticated clients.
    
    For all other clients, we rely on the golang.org/x/net fix in
    golang/net@b225e7c
    That change is not sufficient to adequately protect against a
    motivated client - future changes to Kube and/or golang.org/x/net
    will be explored to address this gap.
    
    The Kube API server now uses a max stream of 100 instead of 250
    (this matches the Go http2 client default).  This lowers the abuse
    limit from 1000 to 400.
    
    Signed-off-by: Monis Khan <mok@microsoft.com>
    
    Kubernetes-commit: 238d89c9a068dcd7ab994be1b3e646ce8d296ef8
    enj authored and k8s-publishing-bot committed Oct 8, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    wyattjoh Wyatt Johnson
    Copy the full SHA
    68b0397 View commit details

Commits on Oct 10, 2023

  1. .: bump golang.org/x/net to v0.17.0

    Bumping golang.org/x/net in light of CVE-2023-39325 and CVE-2023-44487.
    
    Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
    
    Kubernetes-commit: 1cd2ac99542ad0b9f82e3c0177ed3c3e18465136
    MadhavJivrajani authored and k8s-publishing-bot committed Oct 10, 2023
    Copy the full SHA
    1449f93 View commit details

Commits on Oct 12, 2023

  1. Merge pull request #121128 from MadhavJivrajani/bump-x-net-128

    [1.28][CVE-2023-39325] .: bump golang.org/x/net to v0.17.0
    
    Kubernetes-commit: f86a84670e550f31e04df95bd32b0cf035629a0d
    k8s-publishing-bot committed Oct 12, 2023
    Copy the full SHA
    1f3a244 View commit details
  2. Merge pull request #121196 from enj/automated-cherry-pick-of-#121120-…

    …upstream-release-1.28
    
    Prevent rapid reset http2 DOS on API server (disabled by default)
    
    Kubernetes-commit: 51b96deeba61fdc6d590f58a37dd7b6d61c936ac
    k8s-publishing-bot committed Oct 12, 2023
    Copy the full SHA
    ab8b4c8 View commit details
Loading