Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake client patch does not work if object is not found #1323

Open
mishindm opened this issue Dec 19, 2023 · 3 comments
Open

fake client patch does not work if object is not found #1323

mishindm opened this issue Dec 19, 2023 · 3 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mishindm
Copy link

We have the error after Get returning "object not found" error

obj, err := tracker.Get(gvr, ns, action.GetName())

However k8s will create a new object if the patch type == ApplyPatchType

@mishindm
Copy link
Author

A basic implementation (obviously without necessary checks) but working for us:

                        if err != nil {
                                if errors.IsNotFound(err) && action.GetSubresource() == "" {
                                        switch action.GetPatchType() {
                                        case types.ApplyPatchType:
                                                body := map[string]interface{}{}
                                                err := json.Unmarshal(action.GetPatch(), &body)
                                                if err != nil {
                                                        return true, nil, err
                                                }
                                                objcopy := &unstructured.Unstructured{
                                                        Object: body,
                                                }
                                                err = tracker.Create(gvr, objcopy, ns)
                                                if err != nil {
                                                        return true, nil, err
                                                }
                                                obj, err = tracker.Get(gvr, ns, action.GetName())
                                                return true, obj, err
                                        }

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants