Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a clusterID and using on useragent #787

Open
rikatz opened this issue Dec 8, 2023 · 2 comments
Open

Adding a clusterID and using on useragent #787

rikatz opened this issue Dec 8, 2023 · 2 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rikatz
Copy link

rikatz commented Dec 8, 2023

What would you like to be added?

Hey folks,

During some debugging with CSI and CAPV, we've figured out some sessions being opened a lot to vCenter and VAPI, and in fact we got some improvements from it.

One thing that was really helpful on CSI side was the fact that they have implemented the clusterID as part of the userAgent, so listing vc sessions (govc session.ls) allowed us to summarize how many connections each cluster/CSI was opening, if the session was stuck, if it was same userAgent and different nodes (some leader election issue?), etc.

I would like to request that we consider the same for vSphere CPI. I couldn't find on the code any reference on setting the clusterID as a config, so I wanted to understand if:

  • We can add this extra configuration on yaml config (and make it clear that right now this information is only used for userAgent)
  • We can mutate userAgent to, in case clusterID is set, being part of its composition

Thanks

Why is this needed?

Facilitate investigation on VC session leaks, stale connections, add better observation on who/what cluster is consuming connections

@rikatz rikatz added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 8, 2023
@lubronzhan
Copy link
Contributor

Sounds like a good idea. Yeah we don't have any existing clusterID parameter passed. So you can pass it from yaml config or as an arg of command.

@rikatz
Copy link
Author

rikatz commented Dec 8, 2023

cool, thjanks!
/triage accepted
/assign @rikatz

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants