applyconfiguration-gen do not handle slices of pointers correctly

[vflaux]

For the following struct:

type Foo struct {
  Bar []*string `json:"bar,omitempty"`
}

applyconfiguration-gen generate the following "With" function:

func (b *Foo ) WithBar(values ...*string) *Bar{
	for i := range values {
		if values[i] == nil {
			panic("nil value passed to WithBar")
		}
		b.Bar = append(b.Bar, *values[i])
	}
	return b
}

Which causes cannot use *values[i] (variable of type string) as *string value in argument to append
values[i] should not be dereferenced.
The correct code is:

func (b *Foo ) WithBar(values ...*string) *Bar{
	for i := range values {
		if values[i] == nil {
			panic("nil value passed to WithBar")
		}
-		b.Bar = append(b.Bar, *values[i])
+		b.Bar = append(b.Bar, values[i])
	}
	return b
}

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale