Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support angular/material v16.x.x #7800

Open
shu-mutou opened this issue Jun 6, 2023 · 5 comments · May be fixed by #8345
Open

Support angular/material v16.x.x #7800

shu-mutou opened this issue Jun 6, 2023 · 5 comments · May be fixed by #8345
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@shu-mutou
Copy link
Contributor

What should be cleaned up or changed?

KubernetesDashboard uses angular v15.x, but angular/material v15.x.x breaks layout. So we uses angular/material v14.2.2 for now.

Why is this needed?

To support the same version of the other angular component, we need to fix the layout issue.
@shu-mutou shu-mutou added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 6, 2023
@shu-mutou shu-mutou mentioned this issue Jun 6, 2023
Closed
@shu-mutou shu-mutou mentioned this issue Oct 3, 2023
Closed
@shu-mutou
Copy link
Contributor Author

/retitle Support angular/material v16.x.x

@k8s-ci-robot k8s-ci-robot changed the title Support angular/material v15.x.x Support angular/material v16.x.x Oct 3, 2023
romdhanisam added a commit to romdhanisam/dashboard that referenced this issue Oct 5, 2023
@romdhanisam
feat(angular-material): downgrade cdk, animation to 14
a4aafde 
upgrade angular-material to 16
fixes: kubernetes#7800

BREAKING CHANGE: ⛵upgrade angular-material to 16
Signed-off-by: romdhanisamir94@gmail.com
romdhanisam added a commit to romdhanisam/dashboard that referenced this issue Oct 5, 2023
@romdhanisam
feat(angular-material): Updates the Angular Material to v15 & Angular…
82bd9fa 
… CDK to v15

upgrade angular-material to 16
fixes: kubernetes#7800

BREAKING CHANGE: ⛵upgrade angular-material to 16
Signed-off-by: romdhanisamir94@gmail.com
romdhanisam added a commit to romdhanisam/dashboard that referenced this issue Oct 5, 2023
@romdhanisam
feat(angular-material): Generate mdc-migration
7af192f 
upgrade angular-material to 16
TO FIX: TODO(mdc-migration)
fixes: kubernetes#7800

BREAKING CHANGE: ⛵upgrade angular-material to 16
Signed-off-by: romdhanisamir94@gmail.com
romdhanisam added a commit to romdhanisam/dashboard that referenced this issue Oct 5, 2023
@romdhanisam
feat(angular-material): Updates the Angular Material to v16 & Angular…
5c50940 
… CDK to v16

upgrade angular-material to 16
fixes: kubernetes#7800

BREAKING CHANGE: ⛵upgrade angular-material to 16
Signed-off-by: romdhanisamir94@gmail.com
@romdhanisam romdhanisam linked a pull request Oct 9, 2023 that will close this issue
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@romdhanisam
Copy link
Contributor

review #8345

@vaibhav2107
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
5 participants
@shu-mutou @romdhanisam @k8s-ci-robot @k8s-triage-robot @vaibhav2107