Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No fill on workload charts for some languages #8753

Open
romain-rossi opened this issue Mar 7, 2024 · 1 comment · May be fixed by #9067
Open

No fill on workload charts for some languages #8753

romain-rossi opened this issue Mar 7, 2024 · 1 comment · May be fixed by #9067
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@romain-rossi
Copy link

What happened?

When I change the language from "English" to "French" (for example) the workload charts become black (no fill):

image

What did you expect to happen?

The charts should be green ("Running" status)

How can we reproduce it (as minimally and precisely as possible)?

  1. install the 7.0.0 chart version
  2. go to settings and change the language from "English" to "French"

Anything else we need to know?

The issue seems to be related to the method:

getCustomColor(label: string): string {
if (label.includes($localize`Running`)) {
return '#00c752';
} else if (label.includes($localize`Succeeded`)) {
return '#006028';
} else if (label.includes($localize`Pending`)) {
return '#ffad20';
} else if (label.includes($localize`Failed`)) {
return '#f00';
}
return '';
}

and the translations:

<trans-unit id="2956098160626271284" datatype="html">
<source>Running</source>
<target>En fonctionnement</target>
</trans-unit>

<trans-unit id="7873445996550708978" datatype="html">
<source>Running: <x id="PH" equiv-text="status.running"/></source>
<target>En cours d&apos;exécution: <x id="PH" equiv-text="status.running"/></target>
</trans-unit>

In french, the translation En cours d&apos;exécution: X does not include En fonctionnement so the color is not resolved.

FYI, in the previous version, the above translations contain En fonctionnement

Related issue: #7515

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

Kubernetes Dashboard version

7.0.0 (web 1.2.0)

Kubernetes version

1.27.10

Dev environment

No response

@romain-rossi romain-rossi added the kind/bug Categorizes issue or PR as related to a bug. label Mar 7, 2024
@chri4774
Copy link

chri4774 commented Apr 5, 2024

I've noticed the same problem while migrating from v2.7.0 (HELM Release 6.0.8) to 7.2.0 and using german language in the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants