Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-promo job is hitting quota limits #6431

Open
schrej opened this issue Feb 14, 2024 · 7 comments
Open

image-promo job is hitting quota limits #6431

schrej opened this issue Feb 14, 2024 · 7 comments
Labels
area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@schrej
Copy link
Member

schrej commented Feb 14, 2024

The image-promo prow job is failing a lot more frequently than usual (6x in 5h): https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/post-k8sio-image-promo

It looks like it's hitting quota limits on various regional GCP registries. Maybe the total amount of images is too high for the current limits.

two examples:

11347b163438dc07aabfb3ddb651c785b4830f379c1ca6b57bd4939e7e29c895.sig: fetching \"asia-south1-docker.pkg.dev/k8s-artifacts-prod/images/kube-proxy-ppc64le:sha256-11347b163438dc07aabfb3ddb651c785b4830f379c1ca6b57bd4939e7e29c895.sig\": GET https://asia-south1-docker.pkg.dev/v2/k8s-artifacts-prod/images/kube-proxy-ppc64le/manifests/sha256-11347b163438dc07aabfb3ddb651c785b4830f379c1ca6b57bd4939e7e29c895.sig: TOOMANYREQUESTS: Quota exceeded for quota metric 'Requests per project per user' and limit 'Requests per project per user per minute per user' of service 'artifactregistry.googleapis.com' for consumer 'project_number:388270116193'." diff=12ms
time="15:40:40.771" level=fatal msg="run `cip run`: promote images: signing images: replicating signatures: copying signature europe-west9-docker.pkg.dev/k8s-artifacts-prod/images/capi-ipam-ic/cluster-api-ipam-in-cluster-controller:sha256-2fa62384935b0233f68acf75fcb12bbe149b7f122e83d4e5f67f157e73998732.sig to australia-southeast1-docker.pkg.dev/k8s-artifacts-prod/images/capi-ipam-ic/cluster-api-ipam-in-cluster-controller:sha256-2fa62384935b0233f68acf75fcb12bbe149b7f122e83d4e5f67f157e73998732.sig: HEAD https://australia-southeast1-docker.pkg.dev/v2/k8s-artifacts-prod/images/capi-ipam-ic/cluster-api-ipam-in-cluster-controller/manifests/sha256-2fa62384935b0233f68acf75fcb12bbe149b7f122e83d4e5f67f157e73998732.sig: unexpected status code 429 Too Many Requests (HEAD responses have no body, use GET for details)" diff=958ms
@schrej schrej added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Feb 14, 2024
@schrej
Copy link
Member Author

schrej commented Feb 14, 2024

/area registry.k8s.io
/area infra/gcp

@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure labels Feb 14, 2024
@BenTheElder
Copy link
Member

The image promoter makes a really high amount of API calls because of the approach to image signatures.

We have not changed the quotas in the infrastructure projects.

/transfer kubernetes-sigs/promo-tools
/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Something went wrong or the destination repo kubernetes/kubernetes-sigs/promo-tools does not exist.

In response to this:

The image promoter makes a really high amount of API calls because of the approach to image signatures.

We have not changed the quotas in the infrastructure projects.

/transfer kubernetes-sigs/promo-tools
/sig release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

The image promoter is at https://github.com/kubernetes-sigs/promo-tools

@chrischdi
Copy link
Member

@BenTheElder
Copy link
Member

This is not getting visibility to the right people, please file a bug with kubernetes-sigs/promo-tools or kubernetes/sig-release.

K8s-Infra is not changing the limits on the backing registries, they are roughly equivalent to the previous non-configurable GCR limits and they're necessary to prevent trivial DOS, even the project itself must not be permitted to self-DOS, and there is no way to exempt a single user.

@chrischdi
Copy link
Member

Opened the issue at promo-tools. Maybe I can find some time to take a look where it could get optimised. Thanks for pointing to the right direction @BenTheElder ! Really appreciating it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants