Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/klog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.120.1
Choose a base ref
...
head repository: kubernetes/klog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.130.0
Choose a head ref
  • 10 commits
  • 12 files changed
  • 5 contributors

Commits on Jan 21, 2024

  1. Copy the full SHA
    200f43e View commit details
  2. Merge pull request #399 from jsoref/spelling-corporation

    chore(*): fix spelling of Intel Corporation
    k8s-ci-robot authored Jan 21, 2024
    Copy the full SHA
    569bb3c View commit details

Commits on Mar 11, 2024

  1. build: fix some linter warnings

    revive in golangci-lint has version v1.56.2 complains about unused named
    parameters. Sometimes names are useful to document the purpose of a
    parameter. Comments are used instead now in those cases.
    pohly committed Mar 11, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    ff7c070 View commit details

Commits on Mar 13, 2024

  1. Merge pull request #402 from pohly/linter-issues

    build: fix some linter warnings
    k8s-ci-robot authored Mar 13, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    ab53041 View commit details

Commits on Jun 10, 2024

  1. examples: fix linter warning

    The newer golangci-lint enables a revive check by default:
    
      output_test/output_test.go:115:42: unused-parameter: parameter 'vmodule' seems to be unused, consider removing or renaming it as _ (revive)
    	newLogger := func(out io.Writer, v int, vmodule string) logr.Logger {
    pohly committed Jun 10, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    d008cfe View commit details
  2. Merge pull request #406 from pohly/linter

    examples: fix linter warning
    k8s-ci-robot authored Jun 10, 2024
    Copy the full SHA
    7af45d6 View commit details

Commits on Jun 11, 2024

  1. Do not acquire lock for file.Sync() fsync call

    1978629634 committed Jun 11, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    79575d8 View commit details
  2. Merge pull request #404 from 1978629634/fsync-freelock

    Do not acquire lock for file.Sync() fsync call
    k8s-ci-robot authored Jun 11, 2024
    Copy the full SHA
    2ee202a View commit details
  3. ktesting: tone down warning about leaked test goroutine

    Not terminating immediately is fairly normal: many controllers
    log "terminating" messages while they shut down, which often is
    right after test completion, if that is when the test cancels the
    context and then doesn't wait for goroutines (which is often
    not possible).
    
    Therefore the warning now only gets printed if that happens after more than 10
    seconds since test completion, and then the warning is only printed as an info
    message, not an error.
    pohly committed Jun 11, 2024
    Copy the full SHA
    cd24012 View commit details

Commits on Jun 15, 2024

  1. Merge pull request #401 from pohly/ktesting-warning-delay

    ktesting: tone down warning about leaked test goroutine
    k8s-ci-robot authored Jun 15, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    16c7d26 View commit details
Loading