-
Notifications
You must be signed in to change notification settings - Fork 219
Comparing changes
Open a pull request
base repository: kubernetes/klog
base: v2.120.1
head repository: kubernetes/klog
compare: v2.130.0
- 10 commits
- 12 files changed
- 5 contributors
Commits on Jan 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 200f43e - Browse repository at this point
Copy the full SHA 200f43eView commit details -
Merge pull request #399 from jsoref/spelling-corporation
chore(*): fix spelling of Intel Corporation
Configuration menu - View commit details
-
Copy full SHA for 569bb3c - Browse repository at this point
Copy the full SHA 569bb3cView commit details
Commits on Mar 11, 2024
-
build: fix some linter warnings
revive in golangci-lint has version v1.56.2 complains about unused named parameters. Sometimes names are useful to document the purpose of a parameter. Comments are used instead now in those cases.
Configuration menu - View commit details
-
Copy full SHA for ff7c070 - Browse repository at this point
Copy the full SHA ff7c070View commit details
Commits on Mar 13, 2024
-
Merge pull request #402 from pohly/linter-issues
build: fix some linter warnings
Configuration menu - View commit details
-
Copy full SHA for ab53041 - Browse repository at this point
Copy the full SHA ab53041View commit details
Commits on Jun 10, 2024
-
The newer golangci-lint enables a revive check by default: output_test/output_test.go:115:42: unused-parameter: parameter 'vmodule' seems to be unused, consider removing or renaming it as _ (revive) newLogger := func(out io.Writer, v int, vmodule string) logr.Logger {
Configuration menu - View commit details
-
Copy full SHA for d008cfe - Browse repository at this point
Copy the full SHA d008cfeView commit details -
Merge pull request #406 from pohly/linter
examples: fix linter warning
Configuration menu - View commit details
-
Copy full SHA for 7af45d6 - Browse repository at this point
Copy the full SHA 7af45d6View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 79575d8 - Browse repository at this point
Copy the full SHA 79575d8View commit details -
Merge pull request #404 from 1978629634/fsync-freelock
Do not acquire lock for file.Sync() fsync call
Configuration menu - View commit details
-
Copy full SHA for 2ee202a - Browse repository at this point
Copy the full SHA 2ee202aView commit details -
ktesting: tone down warning about leaked test goroutine
Not terminating immediately is fairly normal: many controllers log "terminating" messages while they shut down, which often is right after test completion, if that is when the test cancels the context and then doesn't wait for goroutines (which is often not possible). Therefore the warning now only gets printed if that happens after more than 10 seconds since test completion, and then the warning is only printed as an info message, not an error.
Configuration menu - View commit details
-
Copy full SHA for cd24012 - Browse repository at this point
Copy the full SHA cd24012View commit details
Commits on Jun 15, 2024
-
Merge pull request #401 from pohly/ktesting-warning-delay
ktesting: tone down warning about leaked test goroutine
Configuration menu - View commit details
-
Copy full SHA for 16c7d26 - Browse repository at this point
Copy the full SHA 16c7d26View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.120.1...v2.130.0