Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-kompose pre-commit hook #1780

Closed
znd4 opened this issue Dec 12, 2023 · 4 comments
Closed

run-kompose pre-commit hook #1780

znd4 opened this issue Dec 12, 2023 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@znd4
Copy link

znd4 commented Dec 12, 2023

What would you like to be added?

Would it be reasonable to add a.pre-commit-hooks.yaml to the kompose repo? I'd love to write a (probably pretty simple) PR if it seems appropriate.

The goal would be to enable the following .pre-commit-config.yaml

repos:
  - repo: https://github.com/kubernetes/kompose
    rev: ...
    hooks:
      - id: run-kompose # should this just be kompose?
        args: convert -o k8s/
        # not sure about the regex atm, but hopefully you get the idea
        files: "(docker-compose\\.yaml|k8s/*")

This can currently be somewhat implemented with repo: local and language: system, with obvious downsides

repos:
  - repo: local
    hooks:
      - id: run-kompose
        language: system
        entry: kompose ...
        files: ...

Unfortunately, this requires installing kompose separately, ruling out pre-commit.ci, and adding maintenance overhead to CI pipelines.

Why is this needed?

The use-case would basically be to continue to use docker-compose.yaml as our development platform, (at least until we can figure out a `skaffold workflow that works for us).

This might be against the philosophy of "moving people away from docker-compose", so I'd understand not wanting to add this.

@znd4 znd4 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2023
@AhmedGrati
Copy link
Contributor

Currently, I have no objections to this. Thoughts @cdrage?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2024
@cdrage
Copy link
Member

cdrage commented May 29, 2024

Closing due to no activity, let me know if you are able to open a PR for this!

@cdrage cdrage closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants