-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run-kompose pre-commit hook #1780
Comments
Currently, I have no objections to this. Thoughts @cdrage? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Closing due to no activity, let me know if you are able to open a PR for this! |
What would you like to be added?
Would it be reasonable to add a.pre-commit-hooks.yaml to the kompose repo? I'd love to write a (probably pretty simple) PR if it seems appropriate.
The goal would be to enable the following
.pre-commit-config.yaml
This can currently be somewhat implemented with
repo: local
andlanguage: system
, with obvious downsidesUnfortunately, this requires installing kompose separately, ruling out pre-commit.ci, and adding maintenance overhead to CI pipelines.
Why is this needed?
The use-case would basically be to continue to use docker-compose.yaml as our development platform, (at least until we can figure out a `skaffold workflow that works for us).
This might be against the philosophy of "moving people away from docker-compose", so I'd understand not wanting to add this.
The text was updated successfully, but these errors were encountered: