Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to "Watch failed" #122207

Open
jsoref opened this issue Dec 6, 2023 · 3 comments · May be fixed by #122208
Open

Add context to "Watch failed" #122207

jsoref opened this issue Dec 6, 2023 · 3 comments · May be fixed by #122208
Assignees
@jsoref
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 6, 2023

What would you like to be added?

Add some context to retrywatcher.go's Watch failed error.

Why is this needed?

A number of systems (especially argocd) experience a log message of the form:

1 retrywatcher.go:130] "Watch failed" err="context canceled"

To Reproduce

Dunno

Expected behavior

Log messages should give enough context for someone reading them to understand what's going on, i.e. "I tried to do x and a watch failed".

victims

general search: https://github.com/search?q=%22Watch+failed%22+kubernetes+retrywatcher.go&type=issues

argoproj/argo-cd#14134 (comment)
okteto/okteto#3911 (comment)
aws/eks-anywhere#6535 (comment)
devopstales/devopstales.github.io#7 (comment)
#118731 (comment)
open-cluster-management-io/ocm#186 (comment)

filed as kubernetes/client-go#1321
@jsoref jsoref added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 6, 2023
@jsoref jsoref linked a pull request Dec 6, 2023 that will close this issue
Open
@jsoref
Copy link
Contributor Author

jsoref commented Dec 6, 2023

/assign

@jsoref
Copy link
Contributor Author

jsoref commented Dec 6, 2023

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 6, 2023
@cici37
Copy link
Contributor

cici37 commented Dec 7, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsoref jsoref

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

retrywatcher: Supplement logging jsoref/kubernetes
3 participants
@jsoref @cici37 @k8s-ci-robot