Kube-dns should use versioned client-go

[thockin]

In prep to maybe move kube-dns to its own repo, we should adopt the new client lib.

[MrHohn]

Would like to work on this. I'm using versioned client-go for cluster-proportional-autoscaler too.

[MrHohn]

I met some difficulty when tried to use client-go library with current codes.

The main issue is that kube-dns is using informer from "k8s.io/kubernetes/pkg/controller/framework", which is not part of the client-go library. And this pakage continue introduces the dependencies of "k8s.io/kubernetes/pkg/api", "k8s.io/kubernetes/pkg/api/unversioned", "k8s.io/kubernetes/pkg/runtime" etc. And they eventually conflict with the underlying dependencies of "k8s.io/client-go/1.4/kubernetes"

And in kubernetes/client-go#4, people mentioned that somebody proposed a refactoring to the informer and I would need to do more research on it. Or we simply don't use informer. However that will lead to a certain amount of code changes.

[thockin]

ACK. If we're going to do major surgery to kube-dns we should consider
whether that is the right time to switch to coredns or (other). OK to
defer this for now.

On Mon, Sep 12, 2016 at 2:38 PM, Zihong Zheng notifications@github.com
wrote:

I met some difficulty when try to use client-go library with current codes.

The main issue is that kube-dns is using informer from
"k8s.io/kubernetes/pkg/controller/framework"
https://github.com/kubernetes/kubernetes/tree/master/pkg/controller/framework,
which is not part of the client-go library. And this pakage continue
introduces the dependencies of "k8s.io/kubernetes/pkg/api"
https://github.com/kubernetes/kubernetes/tree/master/pkg/api,
"k8s.io/kubernetes/pkg/api/unversioned"
https://github.com/kubernetes/kubernetes/tree/master/pkg/api/unversioned,
"k8s.io/kubernetes/pkg/runtime"
https://github.com/kubernetes/kubernetes/tree/master/pkg/runtime etc.
And they eventually conflict with the underlying dependencies of
"k8s.io/client-go/1.4/kubernetes"
https://github.com/kubernetes/client-go/tree/master/1.4/kubernetes

And in kubernetes/client-go#4
kubernetes/client-go#4, people mentioned that
somebody proposed a refactoring to the informer and I would need to do
more research on it. Or we simply don't use informer. However that will
lead to a certain amount of code changes.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#31929 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVClvipZ8ITL-qyWpu_Wj52yVtqA9ks5qpcZVgaJpZM4JzOYx
.

[MrHohn]

Seems like it is an oversight and folks intended to include this Informer library too.

I will again work on this after this library is included.

[stp-ip]

Coredns has its first release available (https://github.com/miekg/coredns/releases) might be a good time to check it out.

[caesarxuchao]

Seems like it is an oversight and folks intended to include this Informer library too.

Yeah, I'll move informer to the library, too. Perhaps next week.

[thockin]

@bowei is this done now?

[bowei]

It currently uses client-go, but not the versioned one -- opened issue kubernetes/dns#35

[bowei]

closing as this is tracked in the dns repo

[bowei]

/assign

[bowei]

/close