Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MountOptions for local volume #68317

Closed
lichuqiang opened this issue Sep 6, 2018 · 4 comments
Closed

MountOptions for local volume #68317

lichuqiang opened this issue Sep 6, 2018 · 4 comments
Assignees
@lichuqiang
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@lichuqiang
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What you expected to happen:

After #63011 in, we can have block as volume source for local PVs (in fact I think most of the users would behavior this way). So I think it fairly reasonable to add MountOptions support in local volume.
I've indeed received such requirement from my team and also folks from other companies @wenlxie

/cc @msau42 @jsafrane

/sig storage
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Sep 6, 2018
@lichuqiang
Copy link
Contributor Author

/assign

@wenlxie
Copy link
Contributor

wenlxie commented Sep 6, 2018

One case is we need noatime mount option to improve performance.
I think this is a useful feature for local volume.

@lichuqiang
Copy link
Contributor Author

Took a closer look at the code, seems we've already distinguished volume source type, and tried to fetch mountOptions for that of block.
So we might not need to do anything special, but just enable SupportsMountOption() in local volume

This was referenced Sep 28, 2018
Merged
Merged
@lichuqiang
Copy link
Contributor Author

Closing this as related PRs have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lichuqiang lichuqiang

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wenlxie @lichuqiang @k8s-ci-robot