Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ExternalID from NodeSpec #80334

Closed
draveness opened this issue Jul 19, 2019 · 6 comments
Closed

Remove deprecated ExternalID from NodeSpec #80334

draveness opened this issue Jul 19, 2019 · 6 comments
Assignees
@draveness
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@draveness
Copy link
Contributor

Remove deprecated ExternalID from NodeSpec since it should be removed in 1.13

// Deprecated. Not all kubelets will set this field. Remove field after 1.13.
// see: https://issues.k8s.io/61966
// +optional

ref: 61966

/sig node
/kind cleanup
/assign
@draveness draveness added the kind/bug Categorizes issue or PR as related to a bug. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 19, 2019
@draveness
Copy link
Contributor Author

draveness commented Jul 19, 2019 •
edited

/remove-kind bug

@k8s-ci-robot
Copy link
Contributor

@draveness: Those labels are not set on the issue: kind/bu

In response to this:

/remove-kind bu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Jul 19, 2019
@draveness draveness mentioned this issue Jul 19, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2019
@draveness
Copy link
Contributor Author

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 17, 2019
@swatisehgal
Copy link
Contributor

swatisehgal commented Jun 24, 2021 •
edited

#61877 addresses this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@swatisehgal: Closing this issue.

In response to this:

#61877 addressed this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draveness draveness

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove ExternalID from NodeSpec draveness/kubernetes
4 participants
@draveness @swatisehgal @k8s-ci-robot @fejta-bot