Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade grpc dependency #91881

Closed
tedyu opened this issue Jun 8, 2020 · 9 comments
Closed

Upgrade grpc dependency #91881

tedyu opened this issue Jun 8, 2020 · 9 comments
Labels
area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@tedyu
Copy link
Contributor

tedyu commented Jun 8, 2020 •
edited

What happened:
Currently we use grpc v1.26.0
There is a bug where temporary failure of DNS resolution will bring client down until it is restarted. See grpc/grpc-go#3353

What you expected to happen:
We should upgrade to grpc release which has the fix.
Compatibility should be evaluated carefully between the components involved: etcd, api server, controllers, etc

How to reproduce it (as minimally and precisely as possible):

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@tedyu tedyu added the kind/bug Categorizes issue or PR as related to a bug. label Jun 8, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 8, 2020
@iakisme iakisme mentioned this issue Jun 8, 2020
Closed
@BenTheElder
Copy link
Member

blocked on #91266

@tedyu
Copy link
Contributor Author

tedyu commented Jun 13, 2020

One remaining item: #92078 for image building

@nikhita
Copy link
Member

nikhita commented Jun 16, 2020

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 16, 2020
@tedyu
Copy link
Contributor Author

tedyu commented Jun 17, 2020

#92078 has been merged.

@nikhita nikhita mentioned this issue Jul 22, 2020
Closed
@nikhita
Copy link
Member

nikhita commented Jul 22, 2020

Related - #93320

/sig architecture
/area code-organization

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 22, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 19, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tedyu @BenTheElder @nikhita @k8s-ci-robot @fejta-bot