New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to automatically update schedule.yaml
#45762
base: main
Are you sure you want to change the base?
Conversation
bbddca3
to
d85cfec
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ce084d6
to
02cc2be
Compare
3f26596
to
565f42a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
/hold
We're overall wary of having workflows write to GitHub (we'd typically use Prow, but GitHub Actions has gained lots of feature since Prow came into existence).
Let's check that the SIG is happy with this and is confident we can maintain it.
I wonder if we should address #38431 - Split “can approve English content changes” from “can review general website changes” permissions - first. |
I'd like to highlight that the new |
565f42a
to
1ae460b
Compare
02cf82c
to
a91b3c7
Compare
8ddeb24
to
912ef0e
Compare
912ef0e
to
b76ad4e
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b76ad4e
to
bf868be
Compare
bf868be
to
ccd92b0
Compare
This PR now contains only the workflow, the other part got already merged. |
ccd92b0
to
89df646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@kubernetes/sig-docs-leads are we okay to move forward with this? |
/lgtm |
For LGTM on this particular change, let's get it from a SIG tech lead (or a chair acting in their stead). Leaving the existing hold in place. Noting LGTMs from #45762 (comment) and other reviews. As an emeritus tech lead: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any CLA issues expected with this workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we're using the same approach there for example: kubernetes-sigs/downloadkubernetes#630
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
89df646
to
a63678a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes kubernetes/release#3179
cc @kubernetes/release-managers
Preview: https://deploy-preview-45762--kubernetes-io-main-staging.netlify.app/releases