New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency update - Golang 1.22.0 #3280
Comments
Tracking PRs related to go1.22 that we would need to pick to release branches as part of an eventual update to go1.22:
Tracking verification of conditions for bumping go1.21 on release branches:
Tracking the PR that actually bumps to go1.22:
|
kubernetes/kubernetes#120750 is getting cherry-picked in: |
/assign |
add golang/go#65625 as a potential go1.22 regression to track (either until it is resolved, or until we are sure it doesn't impact Kubernetes' use of go) |
maybe we can close this issue and open a new one to track #3280 (comment) wdyt? @liggitt @MadhavJivrajani |
@cpanato I'm not sure I fully understand why we need a new issue - maybe I'm missing something? @liggitt - tracked golang/go#65625 as a regression, thanks! |
I have a slight preference for keeping everything associated with the minor update in a single issue, but it is a little weird for an issue titled go1.22.0 to track the minor update of release branches to an eventual go1.22.x... maybe we could truncate the title to go1.22? |
ok not a problem, was more a suggestion :) we keep this open |
kubernetes/kubernetes#121476 bumped honnef.co/go/tools to v0.4.6 it turns out that release specifically contained a fix for evaluating go1.22: https://github.com/dominikh/go-tools/releases/tag/2023.1.6 please add that to the list of updates tracked in #3280 (comment) needed for go1.22 |
@liggitt good catch! Thanks, I've tracked the PR. |
@pohly FYI ^ |
Do we want to backport golangci-lint v1.55.1 or just bump up honnef.co/go/tools to v0.4.6 on older branches? |
not sure... maybe do an experimental PR to release-1.29 that bumps .go-version to 1.22.0 and just honnef.co/go/tools to v0.4.6 and see if CI passes? if so, maybe limit to just the honnef.co/go/tools bump? |
thanks... can go ahead and mark 1.26 as not backported for all of those because it reached EOL |
release-1.29 is already on golangci-lint v1.55.1 and thus honnef.co/go/tools v0.4.6. release-1.28 and older aren't. When bumping only honnef.co/go/tools v0.4.6 together with Shall I turn those PRs into proper updates of honnef.co/go/tools? |
yes, that would be great |
Now that we are about to start the process of bumping the Go major version on release branches, we have one tracked regression that seems to affect However, this issue is not a bug in Go itself but in There is an attempt at gracefully handing this in go, however that also does not seem to be a sustainable solution: https://go-review.googlesource.com/c/go/+/585019 The workaround here needs to be in runc itself as mentioned here: opencontainers/runc#4233 cc @liggitt |
cc @akhilerm |
Though also we're pretty sure that bug only affects runc with nsenter, which kubelet is not doing, so as long as your runc binary is not with go 1.22 kubelet can be as far as I know. |
Tracking info
Link to any previous tracking issue: #3076
Golang mailing list announcement: for go1.22 https://groups.google.com/g/golang-announce/c/TpowDYVBMoY/m/3YwLkOoOAAAJ
SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1707291164014399
Work items for
Go1.22rc1
kube-cross
image update: golang: Build 1.22rc1 images #3421go-runner
image update: golang: Build 1.22rc1 images #3421releng-ci
image update: golang: Build 1.22rc1 images #3421Work items for
Go1.22rc2
kube-cross
image update: golang: Build 1.22rc2 images #3433go-runner
image update: golang: Build 1.22rc2 images #3433releng-ci
image update: golang: Build 1.22rc2 images #3433After kube-cross image promotion
kubernetes/kubernetes update (
master
): [go] Bump images, dependencies and versions to go 1.22rc2 kubernetes#122889Ensure the following have been updated within the PR:
.go-version
fileAfter go-runner image promotion
distroless-iptables
image update: build distroless-iptables with go1.22rc2 #3440After kubernetes/kubernetes (master) has been updated
k8s-cloud-builder
image update: add configs for 1.30 with go1.22 for k8s-cloudbuilder #3439k8s-ci-builder
image variants update: add configs for 1.30 with go1.22 for k8s-cloudbuilder #3439kubekins
/krte
image updates: Update kubekins to Go 1.22rc2 test-infra#31761Work items for
Go1.22
kube-cross
image update: Build Go 1.22 (1.22.0) images #3454go-runner
image update: Build Go 1.22 (1.22.0) images #3454releng-ci
image update: Build Go 1.22 (1.22.0) images #3454After kube-cross image promotion
kubernetes/kubernetes update (
master
): [go] Bump images, dependencies and versions to go 1.22 kubernetes#123217Ensure the following have been updated within the PR:
.go-version
fileAfter go-runner image promotion
distroless-iptables
image update: build distroless-iptables using go1.22 #3457After distroless-iptables image promotion
kubernetes/kubernetes update (
master
): [go] Bump images, dependencies and versions to go 1.22 kubernetes#123217Ensure the following have been updated within the PR:
After kubernetes/kubernetes (master) has been updated
k8s-cloud-builder
image update: Build k8s-ci-builder and k8s-cloud-bulider with Go 1.22.0 and 1.21.7 #3463k8s-ci-builder
image variants update: Build k8s-ci-builder and k8s-cloud-bulider with Go 1.22.0 and 1.21.7 #3463kubekins
/krte
image updates: Update from golang 1.22rc2 to 1.22 final test-infra#31940Follow-up items
cc: @kubernetes/release-engineering
cc: @liggitt
The text was updated successfully, but these errors were encountered: