Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability in krel announce to send emails via Google OAuth for release managers using personal gmail accounts. #3360

Open
jimangel opened this issue Nov 14, 2023 · 3 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@jimangel
Copy link
Member

What would you like to be added:

I would like to add Google OAuth support to krel announce with a limited scope that allowed krel to "send emails on your behalf." The code would issue a token valid for 1h with the intention that is refreshed upon each execution.

I created a demo here: https://github.com/jimangel/oauth-gmail-test

Slack convo about this demo: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1699902725642849

It seems like it would work, I would just need some help figuring out the best way to add it into the krel codebase.

Why is this needed:

Currently krel announce has options to send post-release announce emails via SendGrid's API (or HTML output for copy / pasting). SendGrid, to combat spam (and possibly other reasons), has become increasingly unreliable:

image

@xmudrii has opened #3175 to explore alternatives and I'm reluctant to combine this issue with it as it only solves for senders that use gmail. There might be a more robust, bulk-sender-friendly, option that can be used by the entire release management team.

/sig release
/area release-eng
/kind feature
/priority important-longterm

@jimangel jimangel added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 14, 2023
@jimangel jimangel self-assigned this Nov 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2024
@xmudrii
Copy link
Member

xmudrii commented Feb 12, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2024
@jimangel
Copy link
Member Author

jimangel commented May 9, 2024

Checking in here too @xmudrii, happy to see this through to completion in Mid-June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants