Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krel release-notes sometimes errors when the user exits their editor #3381

Open
JamesLaverack opened this issue Nov 29, 2023 · 4 comments
Open
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@JamesLaverack
Copy link
Member

JamesLaverack commented Nov 29, 2023

What happened:

Sometimes, intermittently and infrequently, the krel release notes tool will report an error and exit when a user exits their editor when editing release notes.

Users report errors such as:

- Fix note for PR #97252? (y/N) (1/10) 
y
INFO Opening file with editor [vi /var/folders/94/yvfr6pns4vxd1bz_cr2nwpkc0000gn/T/release-notes-map-1064630614.yaml] 
FATA creating Draft PR: while running release notes fix flow: while editing release note: while launching editor: there was a problem with the editor "vi" 

What you expected to happen:

For krel to not error when a user exits their editor normally.

How to reproduce it (as minimally and precisely as possible):

No known reliable reproduction. But it's been reported by multiple users, multiple years apart. Often seen when using vi and not using other editors, but It's not clear if it's anything to do with vi or just because vi is the default.

Anything else we need to know?:

N/A

Environment:

N/A

@JamesLaverack JamesLaverack added area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 29, 2023
@JamesLaverack
Copy link
Member Author

Added kubernetes-sigs/release-utils#98 to add more logging. In existing error logs the error itself isn't exposed in the log line. Hopefully this will help with debugging the next time this comes up.

@JamesLaverack
Copy link
Member Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority labels Nov 29, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2024
@JamesLaverack
Copy link
Member Author

This is waiting to see if it recurs. It could be some time.

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

3 participants