Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes_e2e.py: remove working dir check if --build is specified #32519

Closed
wants to merge 1 commit into from
Closed

kubernetes_e2e.py: remove working dir check if --build is specified #32519

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

The job pull-release-cluster-up is failing right now with:

+ /workspace/scenarios/kubernetes_e2e.py --build=quick --cluster= --down=false --extract=local --gcp-node-image=gci --gcp-nodes=4 --gcp-zone=us-west1-b --provider=gce --test_args=--ginkgo.focus=definitely-not-a-real-focus --timeout=65m
Traceback (most recent call last):
  File "/workspace/scenarios/kubernetes_e2e.py", line 391, in <module>
    main(parse_args())
  File "/workspace/scenarios/kubernetes_e2e.py", line 259, in main
    raise ValueError(k8s)
ValueError: /home/prow/go/src/github.com/kubernetes/release

Reason for that is that the current working directory is already /home/prow/go/src/github.com/kubernetes/release while the script expects to be in kubernetes/kubernetes. It does not seem to matter much for kubetest in which working directory we are, means we can remove the check completely. Also the method add_k8s does not do anything at all which means we can remove it, too.

cc @kubernetes/release-engineering

Should fix kubernetes/release#3588

@saschagrunert
kubernetes_e2e.py: remove working dir check if --build is specified
13e95be 
The job `pull-release-cluster-up` is failing right now with:

```
+ /workspace/scenarios/kubernetes_e2e.py --build=quick --cluster= --down=false --extract=local --gcp-node-image=gci --gcp-nodes=4 --gcp-zone=us-west1-b --provider=gce --test_args=--ginkgo.focus=definitely-not-a-real-focus --timeout=65m
Traceback (most recent call last):
  File "/workspace/scenarios/kubernetes_e2e.py", line 391, in <module>
    main(parse_args())
  File "/workspace/scenarios/kubernetes_e2e.py", line 259, in main
    raise ValueError(k8s)
ValueError: /home/prow/go/src/github.com/kubernetes/release
```

Reason for that is that the current working director is already
`/home/prow/go/src/github.com/kubernetes/release`, while the script
expects to be in `kubernetes/kubernetes`. It does not seem to matter
much for `kubetest` in which working directory we are, means we can
remove the check completely. Also the method `add_k8s` does not do
anything at all which means we can remove it, too.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/scenarios sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 26, 2024
xmudrii
xmudrii approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert, xmudrii
Once this PR has been reviewed and has the lgtm label, please assign spiffxp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member

aojea commented Apr 26, 2024

/assign @BenTheElder

did't we freeze this script?

@BenTheElder
Copy link
Member

/hold

Please stop using scenario scripts. These are a holdover from bootstrap.py.

All jobs should be using prow decorate: true and kubetest2 or their own CI scripts

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@BenTheElder
Copy link
Member

These have been deprecated since 2018 and we've eliminated most of the users https://github.com/kubernetes/test-infra/tree/master/scenarios

@saschagrunert saschagrunert deleted the ke2e-dir branch April 29, 2024 08:36
@saschagrunert
Copy link
Member Author

@BenTheElder I see. We have to move away from push-build.sh, then we can also remove those pull-release-cluster-up jobs. It's still used in kubetest1 and various other places. Do we have any plans to remove kubetest1 sooner than later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@mpherman2 mpherman2 Awaiting requested review from mpherman2

@MushuEE MushuEE Awaiting requested review from MushuEE

Assignees

@BenTheElder BenTheElder

@xmudrii xmudrii

Labels
area/scenarios cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presubmit job pull-release-cluster-up fails consistently
5 participants
@saschagrunert @k8s-ci-robot @aojea @BenTheElder @xmudrii