/retest triggered jobs on a PR that had needs-ok-to-test label

[akhilerm]

What happened:

• There is a PR build(deps): bump google-github-actions/upload-cloud-storage from 2.0.0 to 2.1.0 containerd/containerd#9705 that was raised by dependabot in containerd repo. SInce dependabot is not a member of the containerd org, k8s-ci-robot added the needs-ok-to-test label on the PR.
• A set of github actions started to run and a few of them flaked and failed.
• To restart the failed github action jobs /retest comment was given.
• The failed github action jobs restarted. But along with it 2 prow jobs that were also configured to run on the main branch also started. (These were the first runs of the prow jobs, not a restart as can be seen from here)

What you expected to happen:

• prow jobs should not run on PRs that have needs-ok-to-test label.

How to reproduce it (as minimally and precisely as possible):

• Create a PR in org/repo by a user, where user is not a member of the org. The org/repo also should have trigger_github_workflows set to true in the prow trigger plugin config.
• repo should have both github actions and prow jobs configured.
• Initially the prow jobs wont be triggered since needs-ok-to-test label is present
• After one of the github action job fails, comment retest. This will restart the failed github action job. Also the prow jobs will be started (NOTE: not restarted, it will be freshly triggered.)

Please provide links to example occurrences, if any:

Anything else we need to know?:
The user who commented /retest had write access to the repository.

[akhilerm]

/sig testing

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale