Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed job message persists in PR despite job not being triggered and retired #32438

Open
amirrmonfared opened this issue Apr 12, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@amirrmonfared
Copy link
Contributor

What happened:
I had failed job and it was configured to only be triggered if the yaml files are changed. After I have removed changes from yaml file and rebased and pushed the commit I saw the message include failure still is in the PR but the job has been retired. It's not a blocker but it will mislead the reviewer that has something is failed

What you expected to happen:
To remove the message related to the job that failed previously but was not triggered in the new commit.

How to reproduce it (as minimally and precisely as possible):
Probably you can set a job to trigger on yaml changes like the configuration I mentioned below and then wait for it to fail, then rebase the commit and delete the changes on yaml file and push again.

    - agent: kubernetes
      always_run: false
      run_if_changed: "\\.(yaml|yml)$"
@amirrmonfared amirrmonfared added the kind/bug Categorizes issue or PR as related to a bug. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 12, 2024
@amirrmonfared
Copy link
Contributor Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

2 participants