Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable workload sharding in prow #5195

Closed
0xmichalis opened this issue Oct 26, 2017 · 5 comments
Closed

Enable workload sharding in prow #5195

0xmichalis opened this issue Oct 26, 2017 · 5 comments
Assignees
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature.

Comments

@0xmichalis
Copy link
Contributor

0xmichalis commented Oct 26, 2017

It should be possible to shard the workload in prow between multiple controllers for the same agent. The granularity level needs to be at the job level but we should also support sharding per repositories.

Use-cases:

  • canarying prow changes in repositories other than the core ones
  • we run two Jenkins masters and a custom proxy in between Jenkins and prow and need to get rid of the proxy because it's making debugging hard. I think that the best approach would be to shard based on the jobs so we can effectively shard between the two masters.

/area prow

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Oct 26, 2017
@spxtr
Copy link
Contributor

spxtr commented Oct 26, 2017

Maybe pass a label (list?) as an argument to the controller and have it list only those prowjobs and pods?

@0xmichalis
Copy link
Contributor Author

Yes, that's what I was thinking. We will need to either include or exclude labels in controllers.

@BenTheElder BenTheElder added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 27, 2017
@0xmichalis
Copy link
Contributor Author

/assign

@munnerz
Copy link
Member

munnerz commented Nov 8, 2017

Regarding doing this after #1986, I think we can make use of the new filtering made possible with kubernetes/kubernetes#54660 when constructing a SharedInformerFactory. This should let us limit the results to only those that match a label selector.

@0xmichalis
Copy link
Contributor Author

@munnerz we already fixed sharding. If we ever switch to use informers, we should do it in a way that wouldn't break sharding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants